Allow show() to trigger while ghost-text is visible #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessevdp
changed the title
jessevdp
changed the title
|
Looks good as is, thanks! |
2 tasks
jessevdp
deleted the
fix-manual-menu-show-while-ghost-text-is-visible
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #762: an issue where manually triggering
show()via a key combo (for those of us that don't useauto_show) isn't possible while ghost text is visible.Note that the current "fix" is very low effort. I simply looked at the definition for
cmp.is_visible()and decided to just copy one half of that function without the "ghost text is visible part". This is on purpose! You can interpret this as a draft PR. I'd be glad to refactor this a bit even if that only means splitting acmp.is_menu_visible()helper function. But......I first want to make sure that this fix is desired. I can verify after running this locally that this fixes my issue. But I'm unsure if this breaks anything else.
I'm happy to polish this further, write a test, you name it! Let me know 😆
Thanks for all of the work on
blink.cmp. Thanks to it I now finally have a completion setup that I'm happy with!